Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

celery tasks tests failing #2415

Closed
emdneto opened this issue Apr 12, 2024 · 0 comments · Fixed by #2416
Closed

celery tasks tests failing #2415

emdneto opened this issue Apr 12, 2024 · 0 comments · Fixed by #2416
Labels
bug Something isn't working

Comments

@emdneto
Copy link
Member

emdneto commented Apr 12, 2024

Describe your environment Describe any aspect of your environment relevant to the problem, including your Python version, platform, version numbers of installed dependencies, information about your cloud hosting provider, etc. If you're reporting a problem with a specific version of a library in this repo, please check whether the problem has been fixed on main.

tox -e py39-test-instrumentation-celery

>       self.assertEqual(
            event.attributes[SpanAttributes.EXCEPTION_TYPE], "CustomError"
        )
E       AssertionError: 'tests.celery_test_tasks.CustomError' != 'CustomError'
E       - tests.celery_test_tasks.CustomError
E       + CustomError

instrumentation/opentelemetry-instrumentation-celery/tests/test_tasks.py:128: AssertionError

Steps to reproduce
Describe exactly how to reproduce the error. Include a code sample if applicable.
Run tox -e py39-test-instrumentation-celery

What is the expected behavior?
Pass the tests

What is the actual behavior?
1 test failed

Additional context

Add capture the fully qualified type name for raised exceptions in spans (open-telemetry/opentelemetry-python#3837)

@emdneto emdneto added the bug Something isn't working label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant