Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Remote Write exporter names can have consecutive underscores #1389

Open
Seefooo opened this issue Oct 18, 2022 · 0 comments
Open

Comments

@Seefooo
Copy link
Contributor

Seefooo commented Oct 18, 2022

    [One more requirement](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/data-model.md#prometheus-compatibility:~:text=the%20_%20character.-,Multiple%20consecutive%20_%20characters%20MUST%20be%20replaced%20with%20a%20single%20_%20character.,-The%20Unit%20of). Feel free to open an issue and either do in a follow up PR or I can mark it up for grabs.

Originally posted by @aabmass in #1359 (comment)

The names & labels after going through string sanitization can have consecutive underscores. This can be fixed, but may require some restructure of the code to not clobber the __name__ label.

@Seefooo Seefooo mentioned this issue Oct 18, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant