Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tornado instrumentation default span name #133

Closed
lzchen opened this issue Nov 3, 2020 · 3 comments
Closed

Fix tornado instrumentation default span name #133

lzchen opened this issue Nov 3, 2020 · 3 comments
Assignees
@owais
Labels
backlog good first issue Good for newcomers help wanted Extra attention is needed instrumentation

Comments

@lzchen
Copy link
Contributor

lzchen commented Nov 3, 2020 •
edited by owais
Loading

Tornado instrumentation uses the handler and handler method name as the span name. It should first try to fetch the URL/route and use that as the span name if possible falling back on the handler name.

Part of #434
@lzchen lzchen changed the title Add hook to set custom span name in starlette instrumentation Fix tornado instrumentation default span name Nov 3, 2020
@codeboten codeboten transferred this issue from open-telemetry/opentelemetry-python Nov 5, 2020
@codeboten codeboten added good first issue Good for newcomers help wanted Extra attention is needed instrumentation labels Nov 5, 2020
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

This issue was marked stale due to lack of activity. It will be closed in 30 days.

@owais owais mentioned this issue Apr 7, 2021
Closed
11 tasks
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this issue needs resolving.

@lzchen
Copy link
Contributor Author

lzchen commented Jun 14, 2021

Fixed with #426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owais owais

Labels
backlog good first issue Good for newcomers help wanted Extra attention is needed instrumentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@owais @codeboten @lzchen