-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[instrumentation-system-metrics] add support for pypy3 #1033
Comments
@codeboten Can I work on this ? if this feature not yet implemented. |
@srikanthccv can you please assign this to me, as we made some progress on this issue. |
@srikanthccv can you please assign this to me, as we made some progress on this issue. |
@srikanthccv Below are the sample output we are getting for PyPy3. Note: Going to create a new file or include in the same file GCHooks Class as mentioned in above link, in order to get the objects for gc in PyPy |
Out of curiosity, @rahulhacker, how did you implement the hook for |
Some of the metrics gathered in
opentelemetry-instrumentation-system-metrics
are different in pypy3. For example, the following method fails on pypy3:module 'gc' has no attribute 'get_count'
Instead, getting counts for garbage collection is done via GC hooks. See the following for more details:
https://doc.pypy.org/en/latest/gc_info.html
The work in this issue is to make the instrumentation either produce all the same metrics or exclude the instruments that don't have equivalents. Ideally at the end of this issue, the tests for this instrumentation library will be enabled in tox for pypy3.
The text was updated successfully, but these errors were encountered: