Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define relationship between profile messages and pprof #545

Closed
jack-berg opened this issue Apr 18, 2024 · 2 comments
Closed

Define relationship between profile messages and pprof #545

jack-berg opened this issue Apr 18, 2024 · 2 comments
Labels
spec:profiles

Comments

@jack-berg
Copy link
Member 

          Does this effectively represent a fork of the upstream definition [here](https://github.com/google/pprof/blob/main/proto/profile.proto)? It seems like it must be we likely have different versioning rules than whatever governs the upstream.

It seems valuable to have comments explaining the relationship between this file and upstream pprof.

Originally posted by @jack-berg in #534 (comment)
@jack-berg jack-berg mentioned this issue Apr 18, 2024
Merged
@tigrannajaryan
Copy link
Member

@open-telemetry/profiling-maintainers It would be very useful to produce a diff between Otel profiles proto and pprof proto definitions and annotate the differences with explanations.

@jack-berg jack-berg changed the title Define relationship between profile messages and prrof Define relationship between profile messages and pprof Apr 18, 2024
@tigrannajaryan
Copy link
Member

This is no longer necessary after decision made here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec:profiles
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tigrannajaryan @jack-berg