Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded clean-gen target #215

Closed
wants to merge 2 commits into from
Closed

Remove unneeded clean-gen target #215

wants to merge 2 commits into from

Conversation

pellared
Copy link
Member

Addresses #214 (comment)

@pellared pellared requested a review from a team as a code owner November 28, 2024 14:12
@pellared pellared mentioned this pull request Nov 28, 2024
Merged
@pellared
Copy link
Member Author

@MikeGoldsmith, @MrAlias, PTAL

MikeGoldsmith
MikeGoldsmith approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@MikeGoldsmith MikeGoldsmith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @pellared. Look like you need a go tidy before merging though.

@MrAlias
Copy link
Contributor

MrAlias commented Dec 2, 2024

The CI failures make me think this was a needed step.

@pellared
Copy link
Member Author

pellared commented Dec 2, 2024 •
edited
Loading

I think we can leave this target as it is.

@pellared pellared closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@dmathieu dmathieu dmathieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pellared @MrAlias @dmathieu @MikeGoldsmith