Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: create an experimental dir #499

Closed
brettmc opened this issue Dec 2, 2021 · 6 comments
Closed

Proposal: create an experimental dir #499

brettmc opened this issue Dec 2, 2021 · 6 comments

Comments

@brettmc
Copy link
Collaborator

brettmc commented Dec 2, 2021

Idea from @tidal in #498 (comment)

One thing thing I found in the repos of other SIGs is, that they often have a experimental directory besides the src one. Maybe we can adport this, so it would be easier to collaborate on certain things, and once everybody is happy, we move it to source?
One reason is, that I find it way easier to review code locally, than in github's PR GUI (There are tools to help with this, but they don't work with the restrictions of the OTEL repos afaik)

To consider:

  • namespace
  • autoloader (dev only?)
  • should not be published to packagist?
@tidal
Copy link
Member

tidal commented Dec 2, 2021

  • namespace

Yes!
If it's a special one (eg. OpenTelemetry/Experimental) it could also host modified version of existing files.

  • autoloader (dev only?)

Yes!

  • should not be published to packagist?

Yes!

@Grunet
Copy link
Contributor

Grunet commented Dec 3, 2021

Just for reference I think this search captures the other repos that do something like this (or at least some of them perhaps)

@tidal
Copy link
Member

tidal commented Dec 4, 2021

@Grunet
Thank you, I did not know that such a great name like "grep.app" exists (no sarcasm, I love it!).
The features are cool too, btw.

@brettmc
Copy link
Collaborator Author

brettmc commented Dec 4, 2021

Another thought - having experimental is good for trying things out, but it would also be useful to use it as a way to collaborate or have others try out prototype code. Having to submit a PR and merge to main is too much friction for collaboration.

@tidal
Copy link
Member

tidal commented Dec 5, 2021

@brettmc
We could use the clones in https://github.com/otel-php for people to collaborate in the future.
I actually created them just to test the sub-splits, but we could keep them to have an easier way to collaborate.
I guess we can add some automation as well, to make this create less friction.

@bobstrecansky
Copy link
Collaborator

It appears you've added this in #498, so I'm going to go ahead and close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants