Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator defaults Nodejs image to the Java auto instrumentation image. #841

Closed
goatsthatcode opened this issue Apr 27, 2022 · 1 comment
Closed

Comments

@goatsthatcode
Copy link
Contributor

The operator defaults for the annotation for which auto-instrumentation image to use is incorrect for node-js:
e.g.

  annotations:
    instrumentation.opentelemetry.io/default-auto-instrumentation-java-image: ghcr.io/open-telemetry/opentelemetry-operator/autoinstrumentation-java:1.11.1
    instrumentation.opentelemetry.io/default-auto-instrumentation-nodejs-image: ghcr.io/open-telemetry/opentelemetry-operator/autoinstrumentation-java:1.11.1
    instrumentation.opentelemetry.io/default-auto-instrumentation-python-image:1.11.1

I would expect this to be instrumentation.opentelemetry.io/default-auto-instrumentation-nodejs-image: ghcr.io/open-telemetry/opentelemetry-operator/autoinstrumentation-nodejs:1.11.1 instead.

@pavolloffay
Copy link
Member

Done in #842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants