Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter fails if adding a file from another project while preserving copyright #611

Closed
mmatache opened this issue Dec 7, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@mmatache
Copy link
Contributor

mmatache commented Dec 7, 2021

This issue relates to: #596

During the implementation, the util functions from Jaeger were used, but since they were small, it was decided to simply copy the files over so as to not add a dependency.

The problem is that we were not able to properly preserve the Jaeger copyright as the goheader linter would error out:

make lint
golangci-lint run
pkg/naming/dns.go:2:4: Actual: Copyright The Jaeger Authors.
Expected: (goheader)
// Copyright The Jaeger Authors.
   ^
make: *** [Makefile:114: lint] Error 1

As such I am opening this ticket to try and figure out a solution for this, as this situation might arise again.

@mmatache mmatache changed the title Linter fails if adding a file from another repository with different copyright Linter fails if adding a file from another project with different copyright Dec 7, 2021
@mmatache mmatache changed the title Linter fails if adding a file from another project with different copyright Linter fails if adding a file from another project while preserving copyright Dec 7, 2021
@jpkrohling jpkrohling added the good first issue Good for newcomers label Dec 7, 2021
@pavolloffay
Copy link
Member

Done in #609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants