You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During the implementation, the util functions from Jaeger were used, but since they were small, it was decided to simply copy the files over so as to not add a dependency.
The problem is that we were not able to properly preserve the Jaeger copyright as the goheader linter would error out:
make lint
golangci-lint run
pkg/naming/dns.go:2:4: Actual: Copyright The Jaeger Authors.
Expected: (goheader)
// Copyright The Jaeger Authors.
^
make: *** [Makefile:114: lint] Error 1
As such I am opening this ticket to try and figure out a solution for this, as this situation might arise again.
The text was updated successfully, but these errors were encountered:
mmatache
changed the title
Linter fails if adding a file from another repository with different copyright
Linter fails if adding a file from another project with different copyright
Dec 7, 2021
mmatache
changed the title
Linter fails if adding a file from another project with different copyright
Linter fails if adding a file from another project while preserving copyright
Dec 7, 2021
This issue relates to: #596
During the implementation, the
util
functions from Jaeger were used, but since they were small, it was decided to simply copy the files over so as to not add a dependency.The problem is that we were not able to properly preserve the Jaeger copyright as the
goheader
linter would error out:As such I am opening this ticket to try and figure out a solution for this, as this situation might arise again.
The text was updated successfully, but these errors were encountered: