Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status object for Instrumentation kind #544

Closed
pavolloffay opened this issue Nov 16, 2021 · 2 comments
Closed

Add status object for Instrumentation kind #544

pavolloffay opened this issue Nov 16, 2021 · 2 comments
Labels
area:auto-instrumentation Issues for auto-instrumentation enhancement New feature or request

Comments

@pavolloffay
Copy link
Member

The instrumentation Kind does not expose any status at the moment. There are a couple of useful fields that the status object can expose:

  1. sampling configuration
  2. exporter config
  3. which workloads are instrumented

I think that showing which workloads are instrumented can be super helpful.

@jpkrohling jpkrohling added the enhancement New feature or request label Nov 17, 2021
@pavolloffay pavolloffay added the area:auto-instrumentation Issues for auto-instrumentation label Jan 31, 2022
@frzifus
Copy link
Member

frzifus commented Feb 17, 2022

Regarding the workloads, what would you recommend as an indicator?
I thought it might make sense to split them by type and store the pod names there.

e.g.:

status:
  instrumented:
    java: ["spring-6d569df946-vqxk8"]
    python: ["flask-54996c6f85-zm5lr"]

Another thing, what do you think about rejected injections as a status field?
We could save the pod names too. However, it is not quite clear to me when they should be removed. Probably when the pod is deleted or the injection was successful.
As an alternative, it probably makes sense to create an event for failed injections and only expose the number of successful and failed injections as status.

It would then look like this:

NAME                   AGE   INSTRUMENTED   REJECTED   OTEL-ENDPOINT               SAMPLE-TYPE                SAMPLE-RATE
my-instrumentation-1   62m   1              3          http://abc-collector:4317   parentbased_traceidratio   0.25

@pavolloffay
Copy link
Member Author

Closing as there is already some status object. Let's improve it case by case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:auto-instrumentation Issues for auto-instrumentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants