Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize mutex lock time in target allocator when updating collectors #414

Closed
alexperez52 opened this issue Aug 27, 2021 · 1 comment
Closed
Assignees

Comments

@alexperez52
Copy link
Contributor

alexperez52 commented Aug 27, 2021

Part of Target Allocator changes

Mutex is locked when collectors are being updated.
Instead, there could be a local var that stores the list of collectors which will replace allocator.collectors. The mutex would then only be locked when the change is ready.

Related PR: #354

@Aneurysm9 Aneurysm9 self-assigned this Sep 15, 2021
@jaronoff97
Copy link
Contributor

We've overhauled how this works and this should be much more efficient now, please let me know if you run into more performance problems here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants