Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically set GOMEMLIMIT for collector, TA, bridge, etc. #2919

Closed
jaronoff97 opened this issue May 1, 2024 · 5 comments · Fixed by #2933
Closed

Automatically set GOMEMLIMIT for collector, TA, bridge, etc. #2919

jaronoff97 opened this issue May 1, 2024 · 5 comments · Fixed by #2933
Labels
area:collector Issues for deploying collector area:opamp Issues for the opamp resource area:target-allocator Issues for target-allocator enhancement New feature or request help wanted Extra attention is needed

Comments

@jaronoff97
Copy link
Contributor

Component(s)

collector, target allocator, opamp

Is your feature request related to a problem? Please describe.

It would be awesome if we could automatically set the GOMEMLIMIT for the collector (and TA/Bridge too) when a user sets a limit on the k8s deployment.

Describe the solution you'd like

when we create the deployment/sts/daemon we could read the resource limit and if present set GOMEMLIMIT to 80% of that per the recommendation here

Describe alternatives you've considered

No response

Additional context

No response
@jaronoff97 jaronoff97 added enhancement New feature or request needs triage labels May 1, 2024
@pavolloffay
Copy link
Member

+1

@pavolloffay pavolloffay added help wanted Extra attention is needed area:target-allocator Issues for target-allocator area:collector Issues for deploying collector area:opamp Issues for the opamp resource and removed needs triage labels May 2, 2024
@jaronoff97
Copy link
Contributor Author

I will be implementing it for GOMAXPROCS as well (related)

@jaronoff97
Copy link
Contributor Author

related: #1456

@jaronoff97 jaronoff97 mentioned this issue May 7, 2024
Merged
@iblancasa
Copy link
Contributor

Do we want to do it for the collector or just rely on this new component? open-telemetry/opentelemetry-collector-contrib#30289

@jaronoff97
Copy link
Contributor Author

i think it still makes sense for us to set this for users outside of that feature, this is a pretty known pattern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:collector Issues for deploying collector area:opamp Issues for the opamp resource area:target-allocator Issues for target-allocator enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
3 participants
@iblancasa @pavolloffay @jaronoff97