Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Allocator loses targets discovered when collector instances take time to come up #2350

Closed
rashmichandrashekar opened this issue Nov 14, 2023 · 1 comment
Labels
area:target-allocator Issues for target-allocator bug Something isn't working

Comments

@rashmichandrashekar
Copy link
Contributor

rashmichandrashekar commented Nov 14, 2023

Component(s)

target allocator

What happened?

Description

In a kubernetes cluster, have scrape jobs configured using TargetAllocator. Due to timing issue(which is very common with kubernetes clusters, where no ordering can be guaranteed), the instances are not discovered until after the first set of targets are discovered. The configuration applied until the instances are discovered are lost.

Steps to Reproduce

Delay the collector instance creation (hard to reproduce since it happens due to timing issue)

Expected Result

The targets discovered should be retained so that they can be assigned whenever the collector instances come up

Actual Result

The targets discovered before the collector instances come up are lost.

Kubernetes Version

1.25.11

Operator version

v0.85.0

Collector version

v0.85.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

Log output

No collector instances present, cannot set targets

Additional context

Have created a PR to fix this - #2351

@jaronoff97
Copy link
Contributor

closed by #2351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:target-allocator Issues for target-allocator bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants