Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate basic reconcile functionality into a reusable package #1876

Closed
avadhut123pisal opened this issue Jun 28, 2023 · 1 comment · Fixed by #1995
Closed

Isolate basic reconcile functionality into a reusable package #1876

avadhut123pisal opened this issue Jun 28, 2023 · 1 comment · Fixed by #1995
Assignees
Labels
area:opamp Issues for the opamp resource

Comments

@avadhut123pisal
Copy link
Contributor

I would propose to open a separate PR to isolate basic reconcile functionality e.g. methods like expected.../delete... into a reusable package. Or even better refactor the code and use mutate func for all object types e.g. https://github.com/grafana/tempo-operator/blob/main/internal/manifests/mutate.go#L27 with https://github.com/grafana/tempo-operator/blob/1a49fbb282ff1596fd874887341b80192eecffc1/controllers/tempo/tempostack_controller.go#L250

Originally posted by @pavolloffay in #1559 (comment)

@jaronoff97
Copy link
Contributor

I can take this on :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:opamp Issues for the opamp resource
Projects
None yet
2 participants