We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I would propose to open a separate PR to isolate basic reconcile functionality e.g. methods like expected.../delete... into a reusable package. Or even better refactor the code and use mutate func for all object types e.g. https://github.com/grafana/tempo-operator/blob/main/internal/manifests/mutate.go#L27 with https://github.com/grafana/tempo-operator/blob/1a49fbb282ff1596fd874887341b80192eecffc1/controllers/tempo/tempostack_controller.go#L250
expected...
delete...
Originally posted by @pavolloffay in #1559 (comment)
The text was updated successfully, but these errors were encountered:
I can take this on :)
Sorry, something went wrong.
jaronoff97
Successfully merging a pull request may close this issue.
I would propose to open a separate PR to isolate basic reconcile functionality e.g. methods like
expected...
/delete...
into a reusable package. Or even better refactor the code and use mutate func for all object types e.g. https://github.com/grafana/tempo-operator/blob/main/internal/manifests/mutate.go#L27 with https://github.com/grafana/tempo-operator/blob/1a49fbb282ff1596fd874887341b80192eecffc1/controllers/tempo/tempostack_controller.go#L250Originally posted by @pavolloffay in #1559 (comment)
The text was updated successfully, but these errors were encountered: