-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[target allocator] Replace deprecated gorilla/mux
dependency
#1352
Comments
(also if there's agreement on this, happy to take this / propose and replace with an alternative 🙃) |
cc) @jaronoff97 @matej-g thanks for reporting this. Do you have any good alternatives in mind? |
Not sure what else is commonly used within Go projects these days, in other projects I'm involved in we use https://github.com/go-chi/chi and we had good experience with it. |
seems that only effects the |
Is there any specific need to such a framework? As far as I can see, the only functionality that is not in the std lib is the query of the url path variable {job_id}. |
Hm that's also a good point @frzifus, I think I can try to prepare a PR with either alternative (standard lib or one of the frameworks if we need the extra features) and we could continue from there. |
@matej-g that would be great, thank you! My worry with the standard library is that if we need to use features that something like gin or chi provide how hard it would be to switch? If it's low enough and we can make it work with the stdlib, then let's go that route. Either way having a PR to compare would be super helpful. Thank you again @matej-g. |
Awesome, I will have a look soon. :) |
The allocator server uses the router from
gorilla/mux
, however the project has been deprecated recently (https://github.com/gorilla#gorilla-toolkit) and is no longer actively maintained. We should replace it with an alternative that's still maintained.The text was updated successfully, but these errors were encountered: