Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Allocator builds are broken #1139

Closed
jaronoff97 opened this issue Oct 4, 2022 · 1 comment · Fixed by #1140
Closed

Target Allocator builds are broken #1139

jaronoff97 opened this issue Oct 4, 2022 · 1 comment · Fixed by #1140

Comments

@jaronoff97
Copy link
Contributor

jaronoff97 commented Oct 4, 2022

It seems the target allocator builds are failing to push new images. I'm seeing this error in the action logs:

Error: buildx failed with: ERROR: tag is needed when pushing to registry

The code for the action hasn't changed at all, but the fix seems like we just need to add a tag to the command. This may be a good time to begin versioning the target allocator rather than keeping it on 0.1.0.

Maybe it makes sense to keep the TA in step with the operator and collector builds, releasing it at the same time as the operator? Would that be a hindrance to our development efforts?

Thoughts? @secustor @Aneurysm9 @kristinapathak

Before

/usr/bin/docker buildx build
--build-arg version=0.1.0
--cache-from type=local,src=/tmp/.buildx-cache
--cache-to type=local,dest=/tmp/.buildx-cache
--iidfile /tmp/docker-build-push-kotdqN/iidfile
--label org.opencontainers.image.title=opentelemetry-operator
--label org.opencontainers.image.description=Kubernetes Operator for OpenTelemetry Collector
--label org.opencontainers.image.url=https://github.com/open-telemetry/opentelemetry-operator
--label org.opencontainers.image.source=https://github.com/open-telemetry/opentelemetry-operator
--label org.opencontainers.image.version=0.1.0
--label org.opencontainers.image.created=2022-09-16T08:06:13.469Z
--label org.opencontainers.image.revision=5c3e2867f38e0eb1d203a76485ea9f99e05e1f11
--label org.opencontainers.image.licenses=Apache-2.0
--platform linux/amd64,linux/arm64
--tag ghcr.io/open-telemetry/opentelemetry-operator/target-allocator:0.1.0
--tag ghcr.io/open-telemetry/opentelemetry-operator/target-allocator:latest
--metadata-file /tmp/docker-build-push-kotdqN/metadata-file
--push cmd/otel-allocator

Currently

/usr/bin/docker buildx build
--build-arg version=
--cache-from type=local,src=/tmp/.buildx-cache
--cache-to type=local,dest=/tmp/.buildx-cache
--iidfile /tmp/docker-build-push-OjBQt3/iidfile
--label org.opencontainers.image.title=opentelemetry-operator
--label org.opencontainers.image.description=Kubernetes Operator for OpenTelemetry Collector
--label org.opencontainers.image.url=https://github.com/open-telemetry/opentelemetry-operator
--label org.opencontainers.image.source=https://github.com/open-telemetry/opentelemetry-operator
--label org.opencontainers.image.version=
--label org.opencontainers.image.created=2022-10-04T07:21:29.400Z
--label org.opencontainers.image.revision=942ed4dc940ac0143c66cb16d97068ff0292c08b
--label org.opencontainers.image.licenses=Apache-2.0
--platform linux/amd64,linux/arm64
--metadata-file /tmp/docker-build-push-OjBQt3/metadata-file
--push cmd/otel-allocator
@secustor
Copy link
Member

secustor commented Oct 4, 2022

It will slow down the releases but also ease the releasing process.

For now IMO we should keep it in step with the collector to ensure both work with the same API. That way we do not have to track the relation to each other, like we do now with CertManager and the KubernetesAPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants