Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to upgrade the collector using operator before v0.52.0 to the newer version #1117

Closed
pureklkl opened this issue Sep 21, 2022 · 2 comments · Fixed by #1126
Closed

Unable to upgrade the collector using operator before v0.52.0 to the newer version #1117

pureklkl opened this issue Sep 21, 2022 · 2 comments · Fixed by #1126
Labels
area:collector Issues for deploying collector bug Something isn't working

Comments

@pureklkl
Copy link
Contributor

When try to upgrade the collector deployed by operator < 0.52 to a newer version, I met
selector` does not match template `labels

#849 defined a set of static selector labels to fix that mutating the selectors will fail the upgrade reconciliation.

However, it will only work for the versions that are after the fix. I want to upgrade a deployment which is before the fix, to the latest.
It will still fail, because the selector remains unchanged during the reconciliation, i.e. the old selector which included app.kubernetes.io/version got inherited and the new collector labels simply won't match.
https://github.com/open-telemetry/opentelemetry-operator/blob/main/pkg/collector/reconcile/daemonset.go#L93

@pureklkl
Copy link
Contributor Author

keycloak/keycloak-operator#567
Similar scenario happened for keycloak, their solution is to delete the old deployment and recreate a new one when the immutable field need to be changed.
I would like to implement it in OT operator if possible.

@pavolloffay pavolloffay added the area:collector Issues for deploying collector label Sep 23, 2022
@pavolloffay
Copy link
Member

Similar scenario happened for keycloak, their solution is to delete the old deployment and recreate a new one when the immutable field need to be changed.

IIRC this was recommended here in the past as well.

I would like to implement it in OT operator if possible.

PRs are welcome to fix it.

@pavolloffay pavolloffay added the bug Something isn't working label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:collector Issues for deploying collector bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants