refactor(sdk-trace-base): rename activeSpanProcessor private property
#5211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #5211 +/- ##
==========================================
- Coverage 93.15% 93.14% -0.01%
==========================================
Files 315 315
Lines 8113 8102 -11
Branches 1633 1633
==========================================
- Hits 7558 7547 -11
Misses 555 555
|
david-luna
commented
Nov 27, 2024
| @@ -24,6 +24,7 @@ | |||
| ### :house: (Internal) | |||
|
|
|||
| * chore: remove checks for unsupported node versions [#4341](https://github.com/open-telemetry/opentelemetry-js/pull/4341) @dyladan | |||
| * refactor(sdk-trace-base): remove `BasicTracerProvider._registeredSpanProcessors` private property. [#5134](https://github.com/open-telemetry/opentelemetry-js/pull/5177) @david-luna | |||
| * refactor(sdk-trace-base): remove `BasicTracerProvider._registeredSpanProcessors` private property. [#5134](https://github.com/open-telemetry/opentelemetry-js/pull/5134) @david-luna | |||
There was a problem hiding this comment.
note for reviewer: the link was incorrect
david-luna
commented
Nov 27, 2024
| @@ -69,8 +69,7 @@ export class BasicTracerProvider implements TracerProvider { | |||
| private readonly _config: TracerConfig; | |||
| private readonly _tracers: Map<string, Tracer> = new Map(); | |||
| private readonly _resource: IResource; | |||
|
|
|||
| private activeSpanProcessor: MultiSpanProcessor; | |||
| private readonly _activeSpanProcessor: MultiSpanProcessor; | |||
There was a problem hiding this comment.
note for reviewer: also made it readonly because is not meant to be changed once is set in the constructor
pichlermarc
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Closes #5203
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
npm run compileat rootnpm run testat rootChecklist: