-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(semconv): update semantic conventions to 1.28.0 #5181
Conversation
trentm
commented
Nov 19, 2024
•
edited
Loading
edited
- semconv schema "changes": https://github.com/open-telemetry/semantic-conventions/blob/v1.28.0/schemas/1.28.0#L4-L9 (This is the subset of differences from the previous version that includes renames of existing semconv values.)
- semconv changelog: https://github.com/open-telemetry/semantic-conventions/blob/v1.28.0/CHANGELOG.md#v1280
As an overview of the semconv changes, here is the change in just the `git diff | rg '^[-+]export'`
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5181 +/- ##
==========================================
- Coverage 94.57% 94.56% -0.02%
==========================================
Files 314 314
Lines 7961 7961
Branches 1600 1600
==========================================
- Hits 7529 7528 -1
- Misses 432 433 +1
|
The changes from your comment don't seem to match the diff. For example you have this change which I can't find in the PR. I was looking into the casing changes to see if they were caused by a change in semconv or a change in how we render semconv -export const DB_COSMOSDB_OPERATION_TYPE_VALUE_BATCH = "Batch" as const;
+export const DB_COSMOSDB_OPERATION_TYPE_VALUE_BATCH = "batch" as const; |
Looks like it's in |
@@ -5,8 +5,10 @@ set -e | |||
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" | |||
ROOT_DIR="${SCRIPT_DIR}/../../" | |||
|
|||
# freeze the spec version to make SpanAttributess generation reproducible | |||
SPEC_VERSION=v1.27.0 | |||
# Get latest version by running `git tag -l --sort=version:refname | tail -1` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏆 thank you for the note
It does look like it changed in semconv to explicitly be lowercase. It's unfortunate this doesn't show up in schema changes as I like to use that for a quick reference 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can or should provide more details in the changelog, e.g. the known changes mentioned in the schema (in this case, the rename map of messaging.client.published.messages: messaging.client.sent.messages
).
Alternatively we can hold off until new attributes are stabilized and only announce changes then. 🤷 The notes provided in the other semconv PR may be sufficient, as this is expected to have breaking changes.
To provide changelog/release-notes on the changes would require us processing the schema file. We could perhaps link to it and/or the semconv repo's changelog: https://github.com/open-telemetry/semantic-conventions/blob/main/CHANGELOG.md#v1280 The schema and semconv repo CHANGELOG speak only in terms of the string values.
Yah, I suppose we could simplify our work:
|
A linked to the semconv repo's schema and changelog as a minimal starting point. |