From bf6a8bb3cd2bf55e54dc336f5286c2371bbd4e33 Mon Sep 17 00:00:00 2001 From: Wolfgang Therrien Date: Wed, 28 Aug 2024 16:50:13 -0400 Subject: [PATCH 1/2] fix(instrumentation-fetch)! Remove HTTP prefix in span name. --- experimental/CHANGELOG.md | 1 + .../packages/opentelemetry-instrumentation-fetch/src/fetch.ts | 2 +- .../opentelemetry-instrumentation-fetch/test/fetch.test.ts | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 0b37b3aa313..70c9730b712 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -6,6 +6,7 @@ All notable changes to experimental packages in this project will be documented ## Unreleased ### :boom: Breaking Change +* fix(instrumentation-fetch)! Remove HTTP prefix in span name. ### :rocket: (Enhancement) diff --git a/experimental/packages/opentelemetry-instrumentation-fetch/src/fetch.ts b/experimental/packages/opentelemetry-instrumentation-fetch/src/fetch.ts index fedb495d685..0f7be7ee9fc 100644 --- a/experimental/packages/opentelemetry-instrumentation-fetch/src/fetch.ts +++ b/experimental/packages/opentelemetry-instrumentation-fetch/src/fetch.ts @@ -206,7 +206,7 @@ export class FetchInstrumentation extends InstrumentationBase { it('span should have correct name', () => { const span: tracing.ReadableSpan = exportSpy.args[1][0][0]; - assert.strictEqual(span.name, 'HTTP GET', 'span has wrong name'); + assert.strictEqual(span.name, 'GET', 'span has wrong name'); }); it('span should have correct kind', () => { @@ -932,7 +932,7 @@ describe('fetch', () => { ); assert.strictEqual( exportSpy.args[0][0][0].name, - 'HTTP GET', + 'GET', 'wrong span captured' ); From a1df28cf469a0145a92f368d357345729a658ddd Mon Sep 17 00:00:00 2001 From: Wolfgang Therrien Date: Wed, 28 Aug 2024 17:32:41 -0400 Subject: [PATCH 2/2] fix: Add PR number to changelog Signed-off-by: Wolfgang Therrien --- experimental/CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 70c9730b712..ef56c5b20ca 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -6,7 +6,8 @@ All notable changes to experimental packages in this project will be documented ## Unreleased ### :boom: Breaking Change -* fix(instrumentation-fetch)! Remove HTTP prefix in span name. + +* fix(instrumentation-fetch)! Remove HTTP prefix in span name. [#4962](https://github.com/open-telemetry/opentelemetry-js/pull/4962) @wolfgangcodes ### :rocket: (Enhancement)