Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk-node): avoid spurious diag errors for unknown OTEL_NODE_RESOURCE_DETECTORS values #4879

Merged
merged 4 commits into from
Jul 30, 2024
Merged

fix(sdk-node): avoid spurious diag errors for unknown OTEL_NODE_RESOURCE_DETECTORS values #4879

merged 4 commits into from
Jul 30, 2024

Commits on Jul 25, 2024

  1. fix(sdk-node): avoid spurious diag errors for unknown OTEL_NODE_RESOU… 

    …RCE_DETECTORS values

When NodeSDK is configured with explicit 'resourceDetectors' or
with 'autoDetectResources: false', then it should not emit diag
errors about unknown values in OTEL_NODE_RESOURCE_DETECTORS.
This can happen when that envvar is used with
@opentelemetry/auto-instrumentation-node

Closes: open-telemetry/opentelemetry-js-contrib#2311
    @trentm
    trentm committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    aa36f80 View commit details
    Browse the repository at this point in the history

  2. add a changelog entry

    @trentm
    trentm committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    fd741ae View commit details
    Browse the repository at this point in the history

  3. lint:fix

    @trentm
    trentm committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    3a14623 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Merge branch 'main' into tm-avoid-double-getResourceDetectorsFromEnv

    @trentm
    trentm authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    0b05b45 View commit details
    Browse the repository at this point in the history