-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow adding links after span creation #4536
feat: allow adding links after span creation #4536
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4536 +/- ##
==========================================
+ Coverage 90.77% 92.83% +2.05%
==========================================
Files 90 328 +238
Lines 1930 9529 +7599
Branches 417 2050 +1633
==========================================
+ Hits 1752 8846 +7094
- Misses 178 683 +505
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good % changelog nits.
Thanks for working on this. 🙂
I will merge this in when all batched with metrics API changes for the next release (and when all changes-requested reviews are resolved)
Co-authored-by: Marc Pichler <[email protected]>
@martinkuba friendly ping. 🙂 Is this still blocked from your point of view? |
* feat: allow adding links after span creation * update changelog * improve docs * test: increase coverage * Update api/CHANGELOG.md Co-authored-by: Marc Pichler <[email protected]> * update changelog --------- Co-authored-by: Marc Pichler <[email protected]>
Which problem is this PR solving?
Fixes #4476
Short description of the changes
Adds functions to add span links after span creation.
Additionally deleted the test named
should set a link
as it did not test anything and was a duplicate ofshould return ReadableSpan with links
.Type of change
Existing users implementing the span API will see compilation breakage.
Checklist: