Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(opencensus-shim) add an example showing how to use the opencensus shim #3778

Merged
merged 5 commits into from
Jun 14, 2023

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented May 3, 2023

Which problem is this PR solving?

Fixes #3749

Short description of the changes

Add an example app and update the README with some documentation

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Tested the example manually

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@aabmass aabmass changed the title oc shim 5 example oc shim finished state May 3, 2023
@aabmass aabmass changed the title oc shim finished state OpenCensus shim finished state May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #3778 (ef64b28) into main (b7d2fac) will decrease coverage by 0.41%.
The diff coverage is n/a.

❗ Current head ef64b28 differs from pull request most recent head c7416d0. Consider uploading reports for the commit c7416d0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3778      +/-   ##
==========================================
- Coverage   92.88%   92.47%   -0.41%     
==========================================
  Files         297      165     -132     
  Lines        8836     3773    -5063     
  Branches     1814      757    -1057     
==========================================
- Hits         8207     3489    -4718     
+ Misses        629      284     -345     

see 137 files with indirect coverage changes

@aabmass aabmass force-pushed the oc-shim-5-example branch 3 times, most recently from c65a10f to 9d114e9 Compare May 3, 2023 21:27
@aabmass aabmass force-pushed the oc-shim-5-example branch 2 times, most recently from cff7d54 to 6b839e9 Compare May 10, 2023 14:57
@aabmass aabmass force-pushed the oc-shim-5-example branch 2 times, most recently from cd0cffa to c8212b9 Compare May 31, 2023 14:46
@aabmass aabmass changed the title OpenCensus shim finished state chore(opencensus-shim) add an example showing how to use the opencensus shim May 31, 2023
@aabmass aabmass changed the title chore(opencensus-shim) add an example showing how to use the opencensus shim docs(opencensus-shim) add an example showing how to use the opencensus shim May 31, 2023
@aabmass aabmass force-pushed the oc-shim-5-example branch 4 times, most recently from 1a65f04 to b18ee45 Compare June 1, 2023 20:18
@aabmass aabmass marked this pull request as ready for review June 1, 2023 20:18
@aabmass aabmass requested a review from a team June 1, 2023 20:18
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, thanks for adding the example 🙂
I took the liberty to update the @opentelemetry/* to 1.14.0/0.40.0 to make the build pass. 🙂

@pichlermarc pichlermarc merged commit 5912501 into open-telemetry:main Jun 14, 2023
@aabmass
Copy link
Member Author

aabmass commented Jun 14, 2023

Thank you Marc! Appreciate all the reviews

@aabmass aabmass deleted the oc-shim-5-example branch June 14, 2023 15:49
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenCensus trace bridge
3 participants