Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin][Request]: Redis plugin #519

Closed
markwolff opened this issue Nov 11, 2019 · 4 comments · Fixed by #503
Closed

[Plugin][Request]: Redis plugin #519

markwolff opened this issue Nov 11, 2019 · 4 comments · Fixed by #503
Assignees
Milestone

Comments

@markwolff
Copy link
Member

Is your plugin request related to a problem? Please describe.

Redis patching for client queries and connections.

Is it applicable for Node or Browser or both
Node

Do you expect this plugin to be commonly used
Weekly Downloads: 1.3M (https://www.npmjs.com/package/redis)

What version of plugin are you interested in using
Versions: 2.6+

@naseemkullah
Copy link
Member

Will this work for both redis and ioredis ?

@mayurkale22
Copy link
Member

Will this work for both redis and ioredis ?

This package will provide tracing support only on redis, we might add a separate package for ioredis (in future). @markwolff corrrect me, if I am wrong.

@markwolff
Copy link
Member Author

markwolff commented Nov 14, 2019

Yes it would require a separate plugin
census instrumentation reference (https://github.com/census-instrumentation/opencensus-node/tree/master/packages/opencensus-instrumentation-ioredis)

@naseemkullah
Copy link
Member

Thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants