Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes on 9-11-23 break dd-trace #4136

Closed
ksstoneware opened this issue Sep 11, 2023 · 5 comments · Fixed by #4137
Closed

Changes on 9-11-23 break dd-trace #4136

ksstoneware opened this issue Sep 11, 2023 · 5 comments · Fixed by #4137
Labels
bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc

Comments

@ksstoneware
Copy link

ksstoneware commented Sep 11, 2023

What happened?

The most-recent change is causing dd-trace to break with the following errors.

Error: node_modules/dd-trace/index.d.ts(1666,20): error TS[24](https://github.com/---/actions/runs/6146278516/job/16676040443#step:16:25)30: Interface 'import("/home/runner/work/---/node_modules/dd-trace/index").opentelemetry.TracerProvider' incorrectly extends interface 'import("/home/runner/work/---/node_modules/@opentelemetry/api/build/src/trace/tracer_provider").TracerProvider'. The types of 'getTracer(...).startSpan(...).recordException' are incompatible between these types. Type '(exception: Exception, time?: TimeInput) => void' is not assignable to type '{ (exception: Exception, time?: TimeInput): void; (exception: Exception, attributes?: Attributes, time?: TimeInput): void; }'. Types of parameters 'time' and 'attributes' are incompatible. Type 'Attributes' is not assignable to type 'TimeInput'. Type 'Attributes' is missing the following properties from type 'Date': toDateString, toTimeString, toLocaleDateString, toLocaleTimeString, and 37 more. Error: node_modules/dd-trace/index.d.ts(1697,20): error TS2430: Interface 'import("/home/runner/work/---/node_modules/dd-trace/index").opentelemetry.Tracer' incorrectly extends interface 'import("/home/runner/work/---/node_modules/@opentelemetry/api/build/src/trace/tracer").Tracer'. Error: node_modules/dd-trace/index.d.ts(1772,20): error TS24[30](https://github.com/---/actions/runs/6146278516/job/16676040443#step:16:31): Interface 'import("/home/runner/work/---/node_modules/dd-trace/index").opentelemetry.Span' incorrectly extends interface 'import("/home/runner/work/---/node_modules/@opentelemetry/api/build/src/trace/span").Span'. Types of property 'recordException' are incompatible. Type '(exception: Exception, time?: TimeInput) => void' is not assignable to type '{ (exception: Exception, time?: TimeInput): void; (exception: Exception, attributes?: Attributes, time?: TimeInput): void; }'. Error: Process completed with exit code 2.

OpenTelemetry Setup Code

No response

package.json

This is from the dd-trace package.json. It is breaking because it is pulling in the latest patch/minor changes.

"@opentelemetry/api": "^1.0.0",
"@opentelemetry/core": "^1.14.0",

Relevant log output

No response

@ksstoneware ksstoneware added bug Something isn't working triage labels Sep 11, 2023
@pichlermarc pichlermarc added priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc and removed triage labels Sep 11, 2023
@pichlermarc pichlermarc reopened this Sep 11, 2023
@pichlermarc
Copy link
Member

Reopening as we still need to get the release out #4138

@ksstoneware
Copy link
Author

@pichlermarc Thank you for the quick response on this!

@ksstoneware
Copy link
Author

Is there an ETA on the release?

@ksstoneware
Copy link
Author

Things are working again after the most recent release. Thanks!

@pichlermarc
Copy link
Member

@ksstoneware glad to hear!
Closing this as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc
Projects
None yet
2 participants