Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP exporters should set User-Agent header as per specification #3291

Closed
pichlermarc opened this issue Oct 4, 2022 · 8 comments
Closed
Labels
feature-request never-stale spec-feature This is a request to implement a new feature which is already specified by the OTel specification up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@pichlermarc
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently the User-Agent header is not set by our exporters as defined in the specification.

Describe the solution you'd like

The User-Agent Header should be added as OTel OTLP Exporter JavaScript/<exporter version> in all OTLP exporters.

Additional context

Specification: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#user-agent

@pichlermarc pichlermarc added good first issue Good for newcomers feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers spec-feature This is a request to implement a new feature which is already specified by the OTel specification labels Oct 4, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Dec 5, 2022
@pichlermarc
Copy link
Member Author

not stale & working on this.

@pichlermarc pichlermarc removed good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers stale labels Dec 5, 2022
@arminru
Copy link
Member

arminru commented Dec 21, 2022

@pichlermarc See open-telemetry/opentelemetry-specification#3052 for the corrected format.

@dyladan
Copy link
Member

dyladan commented Dec 21, 2022

@pichlermarc any update?

@pichlermarc
Copy link
Member Author

pichlermarc commented Dec 21, 2022

@pichlermarc See open-telemetry/opentelemetry-specification#3052 for the corrected format.

Thanks!

@pichlermarc any update?

@dyladan No, not yet. I did not have time to work on that for a while. Also, it's not a single line change unfortunately.
I'll unassign myself for now in case someone has cycles and wants to pick it up.

Edit: I was not assigned. 😅 Added back the "up-for-grabs" label.

@pichlermarc pichlermarc added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Dec 21, 2022
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@raphael-theriault-swi
Copy link
Contributor

The header is set for all Node.js exporters as of #4397, but still missing for browser exporters. It would probably make sense to centralize the logic in the otlp-exporter-base package.

@pichlermarc
Copy link
Member Author

@raphael-theriault-swi yep - thanks for pointing that out, I completely forgot about this issue. We don't set the User-Agent it used to be prohibited, but it will still lead to error logs in some browsers so we opted not to do it.

I'm closing this issue as we can consider it done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request never-stale spec-feature This is a request to implement a new feature which is already specified by the OTel specification up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

No branches or pull requests

4 participants