Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampler doesn't honor SpanOptions#root #2166

Closed
Flarna opened this issue Apr 28, 2021 · 0 comments · Fixed by #2185
Closed

Sampler doesn't honor SpanOptions#root #2166

Flarna opened this issue Apr 28, 2021 · 0 comments · Fixed by #2185
Assignees
@dyladan
Labels
bug Something isn't working up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@Flarna
Copy link
Member

Flarna commented Apr 28, 2021

Tracer#startSpan() ignores any parent if options.root is true.

The followup call to sampler passes the context as is but not options.root.

As a result the sampler may use a different parent then tracer.
@Flarna Flarna added the bug Something isn't working label Apr 28, 2021
@dyladan dyladan added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Apr 28, 2021
@dyladan dyladan self-assigned this Apr 28, 2021
@dyladan dyladan mentioned this issue May 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyladan dyladan

Labels
bug Something isn't working up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use invalid parent for sampler when options.root dyladan/opentelemetry-js
2 participants
@dyladan @Flarna