Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove core NoopLogger #1738

Closed
dyladan opened this issue Dec 10, 2020 · 0 comments · Fixed by #1746
Closed

Remove core NoopLogger #1738

dyladan opened this issue Dec 10, 2020 · 0 comments · Fixed by #1746
Labels
good first issue Good for newcomers internal up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@dyladan
Copy link
Member

dyladan commented Dec 10, 2020

It's confusing to have a NoopLogger in the API and in the SDK.

@obecny looks like we have a NoopLogger in the API and SDK. I'm going to close this, but open a new issue to remove the core NoopLogger

Originally posted by @dyladan in #1523 (comment)
@dyladan dyladan added enhancement New feature or request good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers internal and removed enhancement New feature or request labels Dec 10, 2020
@srikanthccv srikanthccv mentioned this issue Dec 14, 2020
Merged
@MSNev MSNev mentioned this issue Dec 17, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers internal up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove NoopLogger from sdk and use from api srikanthccv/opentelemetry-js
1 participant
@dyladan