Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Manager: npm or yarn #14

Closed
mayurkale22 opened this issue Jun 3, 2019 · 9 comments
Closed

Package Manager: npm or yarn #14

mayurkale22 opened this issue Jun 3, 2019 · 9 comments
Labels
Discussion Issue or PR that needs/is extended discussion.

Comments

@mayurkale22
Copy link
Member

Decide which package manager to use. Both OpenCensuse Node and opentracing-javascript are using npm.

Originates from #2 (comment)

@mayurkale22 mayurkale22 added the Discussion Issue or PR that needs/is extended discussion. label Jun 3, 2019
@spidergears
Copy link

+1 for yarn

3 similar comments
@vmarchaud
Copy link
Member

+1 for yarn

@rochdev
Copy link
Member

rochdev commented Jun 4, 2019

+1 for yarn

@jinmel
Copy link

jinmel commented Jun 5, 2019

+1 for yarn

@hekike
Copy link
Member

hekike commented Jun 5, 2019

+1 for yarn

Some OSS libraries use npm over yarn to avoid an extra dependency for contribution. I think with documentation this gap can be bridged, also probably yarn is popular enough today.
As yarn is faster which would make it more convenient to manage our many packages and it's dependencies. I advocate for it.

@danielkhan
Copy link
Contributor

danielkhan commented Jun 6, 2019

+1 for npm because it's still the standard.

  • Ease of use: In large deployments at customers, installing open telemetry will be part of the build system. DevOps engineers just got used to npm. Why make them install another dependency?

  • Security: While yarn just uses cloudflare to point back at the npm registry, I have seen cases where the build systems at customers had very strict whitelisting in place and only allowed outbound calls to the npm registry. e.g. it was impossible to make them whitelist one of our servers to pull an additional dependency via URL. In such scenarios npm will be always whitelisted while yarn is way more likely to be not allowed.

  • Politics: There are people that feel better depending on a independent entity like npm compared to yarn which is owned by facebook.

As an APM vendor I would stick to the standards and go with the lowest common denominator if I want to avoid confusion amongst my customers.

@vmarchaud
Copy link
Member

@danielkhan I believe we are just discussing the client we will use in scripts defined in package.json and with lerna. All customers will be free to use either yarn or npm to use OpenTelemetry

@bg451
Copy link
Member

bg451 commented Jun 18, 2019

Has a decision been made here?

@rochdev
Copy link
Member

rochdev commented Jun 19, 2019

The decision is to go with yarn. This was reconfirmed in today's SIG meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Development

No branches or pull requests

8 participants