Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip mongodb TAV runs on node 8 and 10 #949

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Mar 16, 2022

Which problem is this PR solving?

The TAV runs are failing for mongodb

Short description of the changes

Skip the TAV runs for mongodb on node 8 and 10, since mongodb@4 doesn't support those anymore.

mongodb@4 doesn't support legacy node versions.
@rauno56 rauno56 requested a review from a team March 16, 2022 14:46
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #949 (93452e6) into main (acd6a6f) will decrease coverage by 5.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
- Coverage   95.91%   90.48%   -5.44%     
==========================================
  Files          13       16       +3     
  Lines         856     1145     +289     
  Branches      178      253      +75     
==========================================
+ Hits          821     1036     +215     
- Misses         35      109      +74     
Impacted Files Coverage Δ
...tapackages/auto-instrumentations-node/src/utils.ts 97.91% <0.00%> (ø)
...opentelemetry-instrumentation-mongodb/src/types.ts 100.00% <0.00%> (ø)
...try-instrumentation-mongodb/src/instrumentation.ts 68.93% <0.00%> (ø)

@rauno56 rauno56 merged commit 00b1a94 into open-telemetry:main Mar 18, 2022
@rauno56 rauno56 deleted the fix/skip-mongodb-old-node branch March 18, 2022 13:02
@dyladan dyladan mentioned this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants