Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detector for docker container id for cgroup v1 to be added to resource metadata #907

Closed
abhee11 opened this issue Feb 16, 2022 · 2 comments
Closed

Add detector for docker container id for cgroup v1 to be added to resource metadata #907

abhee11 opened this issue Feb 16, 2022 · 2 comments
Assignees
@abhee11
Labels
enhancement New feature or request

Comments

@abhee11
Copy link
Contributor

abhee11 commented Feb 16, 2022

Is your instrumentation request related to a problem? Please describe

Currently there is no support for adding container id to resource metadata by itself. The logic exists in aws detector but not as a standalone module.

Is it applicable for Node or Browser or both?

Node

Do you expect this instrumentation to be commonly used?

Weekly Downloads:

What version of instrumentation are you interested in using?

Versions:

Additional context
@abhee11
Copy link
Contributor Author

abhee11 commented Feb 16, 2022

I am currently working on it. I should be able to open a PR soon.

@abhee11 abhee11 changed the title Add detector for docker container id for cgroup v1 Add detector for docker container id for cgroup v1 to be added to resource metadata Feb 16, 2022
@dyladan dyladan added enhancement New feature or request and removed instrumentation-request labels Feb 16, 2022
@abhee11 abhee11 mentioned this issue Mar 3, 2022
Merged
1 task
@abhee11
Copy link
Contributor Author

abhee11 commented Mar 19, 2022

This enhancement was added and merged .

@abhee11 abhee11 closed this as completed Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhee11 abhee11

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dyladan @abhee11