Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use route as root span name in hapi instrumentation #453

Closed
klaemo opened this issue Apr 26, 2021 · 2 comments · Fixed by #571
Closed

use route as root span name in hapi instrumentation #453

klaemo opened this issue Apr 26, 2021 · 2 comments · Fixed by #571
Assignees
Labels
enhancement New feature or request

Comments

@klaemo
Copy link

klaemo commented Apr 26, 2021

Is your feature request related to a problem? Please describe

Currently the root span name is set by the http instrumentation to a generic name like HTTP GET. Additionally, http.route of the root span is set to the actual http pathname and not the route. So, something like http.route: /events/123 instead of http.route: /events/{eventId}.

This makes traces hard to identify (in Honeycomb in this case):
Bildschirmfoto 2021-04-26 um 14 44 19

The actual hapi route is buried somewhat deep in the trace:
Bildschirmfoto 2021-04-26 um 14 43 02

Describe the solution you'd like to see

Similarly to the way it's done for Koa (#327) and Express (#176, #273) the root span name should be renamed once the route has been determined and http.route should be set to the actual route at that point.

Describe alternatives you've considered

None

Thank you for your work on OpenTelemetry and all these instrumentations :)

@vmarchaud vmarchaud added enhancement New feature or request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Apr 26, 2021
@CptSchnitz
Copy link
Contributor

hi,
I would like to work on this.

@obecny obecny assigned obecny and CptSchnitz and unassigned obecny Jul 12, 2021
@obecny
Copy link
Member

obecny commented Jul 12, 2021

hi,
I would like to work on this.

assigned, thx

@obecny obecny removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants