Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "feat(minification): Add importHelpers and tslib as a dependency (#1545)" #1611

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jul 25, 2023

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1611 (d42efc4) into main (4dc98d3) will decrease coverage by 2.50%.
The diff coverage is n/a.

❗ Current head d42efc4 differs from pull request most recent head 9a11191. Consider uploading reports for the commit 9a11191 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1611      +/-   ##
==========================================
- Coverage   96.06%   93.56%   -2.50%     
==========================================
  Files          14      112      +98     
  Lines         914     5053    +4139     
  Branches      199      934     +735     
==========================================
+ Hits          878     4728    +3850     
- Misses         36      325     +289     

see 98 files with indirect coverage changes

@dyladan dyladan changed the title Revert "feat(minification): Add importHelpers and tslib as a dependency (#1545)" fix: Revert "feat(minification): Add importHelpers and tslib as a dependency (#1545)" Jul 26, 2023
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 🙂

@pichlermarc pichlermarc merged commit e5bca5f into open-telemetry:main Aug 2, 2023
@pichlermarc pichlermarc deleted the revert-1545 branch August 2, 2023 14:18
@dyladan dyladan mentioned this pull request Aug 2, 2023
@dyladan dyladan mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.