Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pg instrumentation crashes when using ES module. #1588

Closed
nlindley opened this issue Jul 14, 2023 · 4 comments · Fixed by #1701
Closed

pg instrumentation crashes when using ES module. #1588

nlindley opened this issue Jul 14, 2023 · 4 comments · Fixed by #1701
Labels
bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies

Comments

@nlindley
Copy link

What version of OpenTelemetry are you using?

  • @opentelemetry/api: 1.4.1
  • @opentelemetry/instrumentation: 0.41.0
  • @opentelemetry/instrumentation-pg: 0.36.0
  • @opentelemetry/sdk-node: 0.41.0
  • @opentelemetry/sdk-trace-base: 1.15.0

What version of Node are you using?

18.16.1

What did you do?

Attempted to instrument pg using the default import.

What did you expect to see?

The app to start.

What did you see instead?

The application crashes on import of the module.

Additional context

We have minimal reproductions of the issue: https://github.com/nlindley/otel-esm-examples/tree/master/pg

@nlindley nlindley added the bug Something isn't working label Jul 14, 2023
@dyladan
Copy link
Member

dyladan commented Jul 19, 2023

I think this is the same as open-telemetry/opentelemetry-js#3976

For now you may be able to just use the previous version until we can provide a fix.

@dyladan dyladan added the priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies label Jul 19, 2023
@klippx
Copy link

klippx commented Jul 24, 2023

Duplicate of #1587

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 25, 2023
@nlindley
Copy link
Author

nlindley commented Oct 2, 2023

This is still an issue. It looks like it might be duplicated by #1693 and fixed by #1701. I’m not sure this should be considered a dupe of #1587 since they’ll likely need addressed individually.

@pichlermarc pichlermarc removed the stale label Oct 4, 2023
@pichlermarc pichlermarc linked a pull request Oct 17, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants