-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(knex): nested queries result in wrong span names #1537
fix(knex): nested queries result in wrong span names #1537
Conversation
9521964
to
1caddef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me but I would prefer if we could remove the any
in favor of a more descriptive type
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1537 +/- ##
=======================================
Coverage 91.37% 91.38%
=======================================
Files 127 127
Lines 6345 6350 +5
Branches 1274 1275 +1
=======================================
+ Hits 5798 5803 +5
Misses 547 547
|
Hey @rauno56 I believe your review is requested in order to merge this. Any chance you can have a look in the near future? |
@rauno56 any chance you have a look at this? |
Hi. @rauno56 is no longer / very rarely working on this library. |
I'm out of office until Tuesday sorry |
Fixes #1535
Which problem is this PR solving?
Short description of the changes