-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opentelemetry-instrumentation-document-load): Add access to performance resource timing object for custom attributes #1529
Merged
pkanal
merged 8 commits into
open-telemetry:main
from
honeycombio:pkanal/add-resource-to-custom-attrs
Jun 28, 2023
Merged
feat(opentelemetry-instrumentation-document-load): Add access to performance resource timing object for custom attributes #1529
pkanal
merged 8 commits into
open-telemetry:main
from
honeycombio:pkanal/add-resource-to-custom-attrs
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
==========================================
- Coverage 96.13% 96.06% -0.08%
==========================================
Files 14 14
Lines 906 914 +8
Branches 197 199 +2
==========================================
+ Hits 871 878 +7
- Misses 35 36 +1
|
…ormance resource timing object for custom attributes
pkanal
force-pushed
the
pkanal/add-resource-to-custom-attrs
branch
from
June 6, 2023 20:48
b134314
to
e402fde
Compare
martinkuba
approved these changes
Jun 27, 2023
MSNev
approved these changes
Jun 28, 2023
pichlermarc
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🙂
Just a few nits from my side :)
plugins/web/opentelemetry-instrumentation-document-load/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
plugins/web/opentelemetry-instrumentation-document-load/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marc Pichler <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Allows access to the
PerformanceResourceTiming
object forresourceFetch
spans to add custom attributes to theresourceFetch
span. This would allow for the ability to add extra span attributes toresourceFetch
spans like some common resource timing metrics.Short description of the changes
_addCustomAttributesOnResourceSpan
that replaces_addCustomAttributesOnSpan
whenresourceFetch
spans are created._addCustomAttributesOnResourceSpan
takes an additionalresource
argument that passesPerformanceResourceTiming
information for each resource to theapplyCustomAttributesOnSpan
callback.