Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataloader instrumentation imports types from the underlying package #1218

Closed
rauno56 opened this issue Oct 5, 2022 · 2 comments · Fixed by #1221
Closed

Dataloader instrumentation imports types from the underlying package #1218

rauno56 opened this issue Oct 5, 2022 · 2 comments · Fixed by #1221
Assignees
Labels
bug Something isn't working pkg:instrumentation-dataloader priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect

Comments

@rauno56
Copy link
Member

rauno56 commented Oct 5, 2022

instrumentation.d.ts of the build assets import types from dataloader:

import type [...] from 'dataloader';

Which means that the compilation fails, if the user has not installed the dataloader package - happens with metapackage users for example.

This needs to be fixed by removing all references to any of the dataloader types from the public APIs.

@rauno56 rauno56 added bug Something isn't working pkg:instrumentation-dataloader labels Oct 5, 2022
@rauno56
Copy link
Member Author

rauno56 commented Oct 5, 2022

@henrinormak, would you like to take it yourself or shall I?

@rauno56 rauno56 self-assigned this Oct 7, 2022
@henrinormak
Copy link
Contributor

Will be fixed by #1221, thanks for spotting and taking care of this! 🙇

@rauno56 rauno56 added the priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:instrumentation-dataloader priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants