feat(opentelemetry-instrumentation-fastify): Support Fastify V4 also

[markrzen]

Which problem is this PR solving?

• Fastify 4.x is not supported (Resolves fix(deps): update dependency fastify to v4 #1074)

Short description of the changes

• Upgrade to semver range to support Fastify 3+
• Update dev dependencies and tests to test against Fastify 4.x

Checklist

• Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: markrzen / name: Mark Reynolds (d46f326)

[vmarchaud]

overall lgtm, could you sign the CLA please ?

[codecov]

Codecov Report

Merging #1164 (6a550ad) into main (cb83d30) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1164      +/-   ##
==========================================
- Coverage   96.08%   96.04%   -0.04%     
==========================================
  Files          14       19       +5     
  Lines         893     1113     +220     
  Branches      191      230      +39     
==========================================
+ Hits          858     1069     +211     
- Misses         35       44       +9     

Impacted Files	Coverage Δ
...try-instrumentation-fastify/src/instrumentation.ts	97.41% <100.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts	98.03% <0.00%> (ø)
...telemetry-instrumentation-fastify/src/constants.ts	100.00% <0.00%> (ø)
...nstrumentation-fastify/src/enums/AttributeNames.ts	100.00% <0.00%> (ø)
...opentelemetry-instrumentation-fastify/src/utils.ts	87.50% <0.00%> (ø)

[markrzen]

@vmarchaud I am waiting on my Corp CLA manager.

[markrzen]

@vmarchaud All done with the CLA.

[vmarchaud]

could you update the readme supported version too ? https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-fastify/README.md#supported-versions. Othersiwe LGTM

[markrzen]

@vmarchaud Yeah, good call. That's added.

[vmarchaud]

@markrzen not sure if you forgotten but you didn't push a modification to include the newly supported version (https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-fastify/README.md?rgh-link-date=2022-09-18T07%3A19%3A00Z#supported-versions)

[markrzen]

@vmarchaud Sorry about that. I didn't know it was also documented on the README. Just pushed that change.

[vmarchaud]

Sorry about that. I didn't know it was also documented on the README. Just pushed that change.

No worries :) I made a comment about it thats why i though you add forgotten it

[markrzen]

@vmarchaud Thanks so much.

[markrzen]

@vmarchaud What's our next step for this PR? Not trying to rush, just making sure I am not missing a step.

[vmarchaud]

@markrzen Just getting more eyes to look at it to verify its fine, we generally require 2-3 reviews to merge

[blumamir]

Can you explain what changed so that now we need this extra check?

[markrzen]

Absolutely. Fastify reworked their namespacing of plugins. All plugins are now under the fastify top level namespace.

What used to be "plugin.name": "my-plugin" is now "plugin.name": "fastify -> my-plugin".

The extra check is there so that if you wanted to switch between fastify versions and run tests, you could and still have consistent results.

Fastify 3.x checking if the plugin name does not exist is enough, for Fastify 4.x the equivalent is to check if the plugin name is just fastify.

If you would like me to remove it from the tests as you don't think y'all will be switching versions, I am totally happy to.

[vmarchaud]

@blumamir if the explaination is fine for you feel free to go ahead and merge this