Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Tracer/MeterFactory to Tracer/MeterRegistry #664

Closed
bogdandrutu opened this issue Nov 5, 2019 · 5 comments · Fixed by #725
Closed

Rename Tracer/MeterFactory to Tracer/MeterRegistry #664

bogdandrutu opened this issue Nov 5, 2019 · 5 comments · Fixed by #725
Assignees

Comments

@bogdandrutu
Copy link
Member

No description provided.

@arminru
Copy link
Member

arminru commented Nov 5, 2019

No description provided.

Where does this requirement originate from?

@bogdandrutu
Copy link
Member Author

I like the names better than Factory. Main reason is that we do have an internal shared state between all Tracers that is owned by the Registry or Factory, usually factories do not share state with elements created.

I don't feel very strong but I do think it is a better name.

@arminru
Copy link
Member

arminru commented Nov 27, 2019

I'm perfectly fine with TracerRegistry and do agree with your considerations, I just didn't know where this issue originated from. Once open-telemetry/opentelemetry-specification#354 is merged we are free to name it either way, I'm all in for TracerRegistry then.

@carlosalberto
Copy link
Contributor

+1 on having it as Registry.

@Oberon00
Copy link
Member

Oberon00 commented Dec 5, 2019

In my python PR (open-telemetry/opentelemetry-python#301) I named it TracerSource because it does not keep track of the created tracers, so registry would be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants