Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Sampler#shouldSample method add a param InstrumentationScopeInfo? #5153

Open
IcebergXTY opened this issue Jan 29, 2023 · 2 comments
Open
Labels
blocked:spec blocked on open or unresolved spec Feature Request Suggest an idea for this project

Comments

@IcebergXTY
Copy link

Is your feature request related to a problem? Please describe.
We need the scope_name to judge if it needs sampler but this parameter does not exist yet.

Describe the solution you'd like
Add the InstrumentationScopeInfo param like this

  SamplingResult shouldSample(
      InstrumentationScopeInfo instrumentationScopeInfo,
      Context parentContext,
      String traceId,
      String name,
      SpanKind spanKind,
      Attributes attributes,
      List<LinkData> parentLinks);
@IcebergXTY IcebergXTY added the Feature Request Suggest an idea for this project label Jan 29, 2023
@jkwatson
Copy link
Contributor

We can figure out how to add this only if it added to the official otel specification.

@jack-berg
Copy link
Member

Here's the spec issue tracking this feature request. @IcebergXTY, it would be helpful if you could describe your use case in that issue.

@jack-berg jack-berg added the blocked:spec blocked on open or unresolved spec label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked:spec blocked on open or unresolved spec Feature Request Suggest an idea for this project
Projects
None yet
Development

No branches or pull requests

3 participants