Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OkHttpSender by default in ZipkinSpanExporter #1409

Closed
trask opened this issue Jul 13, 2020 · 0 comments · Fixed by #1475
Closed

Use OkHttpSender by default in ZipkinSpanExporter #1409

trask opened this issue Jul 13, 2020 · 0 comments · Fixed by #1475
Labels
Feature Request Suggest an idea for this project release:after-ga

Comments

@trask
Copy link
Member

trask commented Jul 13, 2020

See open-telemetry/opentelemetry-java-instrumentation#674 (comment)

except for when the JAR size is extremely limited, Zipkin always recommends using OkHttp in production since performance is way better

And open-telemetry/opentelemetry-java-instrumentation#375 (comment)

The most common http reporter used by Zipkin users is the OkHttp one, it is the default in spring-cloud-sleuth. The URLConnection one exists mostly in the case of classpath issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Suggest an idea for this project release:after-ga
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use OkHttpSender by default in ZipkinSpanExporter trask/opentelemetry-java
2 participants
@trask @jkwatson