From 7eb048d1b08f3343e9c466a63e0b26eb50cb8a09 Mon Sep 17 00:00:00 2001 From: sfriberg Date: Tue, 24 Nov 2020 09:56:05 -0600 Subject: [PATCH] Update comment --- .../io/opentelemetry/sdk/extension/jfr/JfrSpanProcessor.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sdk-extensions/jfr-events/src/main/java/io/opentelemetry/sdk/extension/jfr/JfrSpanProcessor.java b/sdk-extensions/jfr-events/src/main/java/io/opentelemetry/sdk/extension/jfr/JfrSpanProcessor.java index 460df01eda1..2588b19f55b 100644 --- a/sdk-extensions/jfr-events/src/main/java/io/opentelemetry/sdk/extension/jfr/JfrSpanProcessor.java +++ b/sdk-extensions/jfr-events/src/main/java/io/opentelemetry/sdk/extension/jfr/JfrSpanProcessor.java @@ -20,8 +20,9 @@ /** * Span processor to create new JFR events for the Span as they are started, and commit on end. * - *

NOTE: JfrSpanProcessor must be running synchronously to ensure that duration is correctly - * captured. + *

NOTE: The JfrSpanProcessor measures the timing of spans, avoid if possible to wrap it with any + * other SpanProcessor which may affect timings. When possible, register it first before any other + * processors to allow the most accurate measurements. */ public class JfrSpanProcessor implements SpanProcessor {