Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document flags used to capture enduser attributes #9783

Closed
laurit opened this issue Oct 31, 2023 · 5 comments
Closed

Document flags used to capture enduser attributes #9783

laurit opened this issue Oct 31, 2023 · 5 comments
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome documentation Improvements or additions to documentation enhancement New feature or request

Comments

@laurit
Copy link
Contributor

laurit commented Oct 31, 2023

#9751 and #9777 define flags to capture enduser attributes these need to be documented in the website repo where the rest of the common flags are documented.
@philsttr philsttr mentioned this issue Nov 6, 2023
Merged
@mateuszrzeszutek mateuszrzeszutek added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 7, 2023
@breedx-splk breedx-splk added the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Jan 30, 2024
@jaydeluca jaydeluca mentioned this issue Feb 12, 2024
Merged
@jaydeluca
Copy link
Member

I have a draft PR to add these config options: open-telemetry/opentelemetry.io#3982

Is this what you had in mind? If so I will mark the PR as ready for review.

@trask
Copy link
Member

trask commented Feb 12, 2024

there's also these: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/spring/spring-security-config-6.0/javaagent/README.md

@jaydeluca
Copy link
Member

I updated the PR to include those flags. I added a description for their context based on this comment, but if I misinterpreted anything I can update it

@jaydeluca
Copy link
Member

I believe this issue can now be closed as completed unless theres anything else we want documented

@laurit
Copy link
Contributor Author

laurit commented Feb 26, 2024

Thanks.

@laurit laurit closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@trask @laurit @jaydeluca @mateuszrzeszutek @breedx-splk