Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 3rd generic parameter to HttpClientTracer for HEADERS #964

Closed
trask opened this issue Aug 13, 2020 · 1 comment · Fixed by #971
Closed

Add a 3rd generic parameter to HttpClientTracer for HEADERS #964

trask opened this issue Aug 13, 2020 · 1 comment · Fixed by #971
Assignees

Comments

@trask
Copy link
Member

trask commented Aug 13, 2020

HttpClientTracer.startScope() and .getSetter() are not working in some places because the object we want to inject the header into does not have the same type as the request, e.g. #922 (comment)

If there are a few of these places, it may make sense to add a 3rd generic parameter to HttpClientTracer for HEADERS, to make startScope() and getSetter() more broadly applicable.

@trask
Copy link
Member Author

trask commented Aug 13, 2020

As part of this, see if we can get rid of all getSetters() that return null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant