Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeakConcurrentMap-backed InstrumentationContext throws NPE on storing null value #895

Closed
trask opened this issue Aug 5, 2020 · 2 comments
Assignees

Comments

@trask
Copy link
Member

trask commented Aug 5, 2020

This doesn't match behavior for field-backed InstrumentationContext which allows storing null value.

You can reproduce this by disabling the field-backed provider:

System.setProperty("otel.trace.runtime.context.field.injection", "false")

and running GrizzlyAsyncHttpClientTest.

Marking this release:after-ga because otel.trace.runtime.context.field.injection is not a recommended setting, and the WeakConcurrentMap-backed InstrumentationContext mostly exists in the rare case where we don't get to do the initial transform on a class and can only do retransform, which limit ability to make any structural changes to the class (e.g. introduce a field for the field-backed InstrumentationContext).

@trask
Copy link
Member Author

trask commented Sep 24, 2020

Oh! I think this was fixed by #1177, just need to re-test.

@trask trask self-assigned this Sep 24, 2020
@mateuszrzeszutek
Copy link
Member

Re-tested with field-backed provider disabled; cannot reproduce anymore. I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants