Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sporadic test failure (13x): TomcatServlet3Test* #517

Closed
trask opened this issue Jun 14, 2020 · 3 comments
Closed

Sporadic test failure (13x): TomcatServlet3Test* #517

trask opened this issue Jun 14, 2020 · 3 comments

Comments

@trask
Copy link
Member

trask commented Jun 14, 2020 •
edited
Loading

New issue, different from #436

TomcatServlet3TestDispatchAsync:

Condition not satisfied:

accessLogValue.loggedIds.size() == count
|              |         |      |  |
|              |         3      |  4
|              |                false
|              [[bb7f4957fc61666b1c4920138e360c4c, d50a3494965171b3]]
TestAccessLogValve[localhost]

	at TomcatServlet3Test.access log has ids for #count requests_closure3(TomcatServlet3Test.groovy:127)
	at io.opentelemetry.auto.test.asserts.InMemoryExporterAssert.assertTraces(InMemoryExporterAssert.groovy:52)
	at io.opentelemetry.auto.test.AgentTestRunner.assertTraces(AgentTestRunner.java:233)
	at TomcatServlet3Test.access log has ids for #count requests(TomcatServlet3Test.groovy:126)

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-java-instrumentation/1314/workflows/2ad34987-b0fe-4dc0-9cee-5c5b40c70be7/jobs/10704/tests

TomcatServlet3TestDispatchImmediate:

Condition not satisfied:

accessLogValue.loggedIds.size() == count
|              |         |      |  |
|              |         2      |  1
|              |                false
|              [[820da3aadfc5e7dd43ff22d87d093c20, 300f83a898356cbc], [c861d6eabba8a13277247b1f8a1a8918, 5cdd2afce703899b], [c4fe4a119afcd1ac544b8bcb53dde69f, d20b50066b0a98a9], [7b43bdd62a94d7750ef11b36b348c169, 77130968da336be0]]
TestAccessLogValve[localhost]

	at TomcatServlet3Test.access log has ids for #count requests_closure3(TomcatServlet3Test.groovy:127)
	at io.opentelemetry.auto.test.asserts.InMemoryExporterAssert.assertTraces(InMemoryExporterAssert.groovy:52)
	at io.opentelemetry.auto.test.AgentTestRunner.assertTraces(AgentTestRunner.java:233)
	at TomcatServlet3Test.access log has ids for #count requests(TomcatServlet3Test.groovy:126)

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-java-instrumentation/1309/workflows/3028f106-3f4c-4ef9-b391-1cf0ea886a8f/jobs/10667/tests

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-java-instrumentation/1351/workflows/ed5a51aa-5714-4d64-8caa-a5ef04583c27/jobs/10968/tests

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-java-instrumentation/1418/workflows/5b6d2d9b-26a6-46ac-b201-f68b36b71a2b/jobs/11397/tests

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-java-instrumentation/1510/workflows/61fa2512-c576-479e-a657-fecd3cf74499/jobs/11993/tests

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-java-instrumentation/1567/workflows/2b28c9b5-c96c-4329-8bac-6b197447dcba/jobs/12315/tests

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-java-instrumentation/1577/workflows/8a2aed1b-8c4b-45a7-8df1-5f306865ad20/jobs/12379/tests

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-java-instrumentation/1597/workflows/3d9662e1-78e3-4806-a21e-8a682f4062d3/jobs/12503/tests

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-java-instrumentation/1620/workflows/16328c79-d79c-49fd-9b5c-a9be3b490476/jobs/12636

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-java-instrumentation/1765/workflows/d3e1564d-486a-4ed8-9984-2354d6b52f2e/jobs/13212/tests

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-java-instrumentation/1931/workflows/fc641190-2273-4f48-b0fc-2b4d3fa080e8/jobs/13748/tests

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-java-instrumentation/2025/workflows/80539b95-d472-4b45-af8b-1f0cc03b8ce0/jobs/14050/tests
@trask trask added sporadic test failure contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome labels Jun 14, 2020
@trask trask changed the title Sporadic test failure (2x): TomcatServlet3Test* Sporadic test failure (3x): TomcatServlet3Test* Jun 16, 2020
@trask trask changed the title Sporadic test failure (3x): TomcatServlet3Test* Sporadic test failure (4x): TomcatServlet3Test* Jun 22, 2020
@trask trask changed the title Sporadic test failure (4x): TomcatServlet3Test* Sporadic test failure (5x): TomcatServlet3Test* Jun 25, 2020
@iNikem iNikem changed the title Sporadic test failure (5x): TomcatServlet3Test* Sporadic test failure (6x): TomcatServlet3Test* Jun 26, 2020
@trask trask changed the title Sporadic test failure (6x): TomcatServlet3Test* Sporadic test failure (7x): TomcatServlet3Test* Jun 28, 2020
@trask trask changed the title Sporadic test failure (7x): TomcatServlet3Test* Sporadic test failure (8x): TomcatServlet3Test* Jun 29, 2020
@trask trask self-assigned this Jun 29, 2020
@trask trask removed the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Jun 29, 2020
@trask trask changed the title Sporadic test failure (8x): TomcatServlet3Test* Sporadic test failure (9x): TomcatServlet3Test* Jun 29, 2020
@trask trask changed the title Sporadic test failure (9x): TomcatServlet3Test* Sporadic test failure (10x): TomcatServlet3Test* Jun 30, 2020
@trask trask changed the title Sporadic test failure (10x): TomcatServlet3Test* Sporadic test failure (11x): TomcatServlet3Test* Jul 9, 2020
@trask trask changed the title Sporadic test failure (11x): TomcatServlet3Test* Sporadic test failure (12x): TomcatServlet3Test* Jul 17, 2020
@trask trask changed the title Sporadic test failure (12x): TomcatServlet3Test* Sporadic test failure (13x): TomcatServlet3Test* Jul 21, 2020
@trask trask mentioned this issue Aug 1, 2020
Closed
@trask
Copy link
Member Author

trask commented Aug 5, 2020

Closing, we haven't seen this since #814

@trask trask closed this as completed Aug 5, 2020
@trask
Copy link
Member Author

trask commented Aug 5, 2020

Spoke too soon 🙁

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-java-instrumentation/2489/workflows/454303c3-5a3b-40b4-ad83-8598444e0677/jobs/15693/tests

@trask trask reopened this Aug 5, 2020
@trask trask removed their assignment Aug 10, 2020
@trask
Copy link
Member Author

trask commented Aug 12, 2020

Closing per #925

@trask trask closed this as completed Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tomcat context leak
1 participant
@trask