Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closeScopeAndEndSpan execute by 'hasNext()' #2475

Closed
ReiZ-X opened this issue Mar 3, 2021 · 2 comments
Closed

closeScopeAndEndSpan execute by 'hasNext()' #2475

ReiZ-X opened this issue Mar 3, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@ReiZ-X
Copy link

ReiZ-X commented Mar 3, 2021

opentelemetry-java-instrumentation/instrumentation/kafka-clients-0.11/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/kafkaclients/TracingIterator.java

Line 38 in 9f3dfdb

closeScopeAndEndSpan();

where loop iterator, only want process N items(iterator has more than N items), closeScopeAndEndSpan will not execute for the last item
@ReiZ-X ReiZ-X changed the title closeScopeAndEndSpan executed by 'hasNext()' closeScopeAndEndSpan execute by 'hasNext()' Mar 3, 2021
@iNikem iNikem added the bug Something isn't working label Mar 3, 2021
@ReiZ-X
Copy link
Author

ReiZ-X commented Mar 8, 2021

'break' offen appear in loop. also lead to unclosed span.

@trask
Copy link
Member

trask commented May 3, 2022

Consolidating into #1947

@trask trask closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trask @iNikem @ReiZ-X