Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tracing the ClickHouse Java HTTP client #11562

Closed
devurandom opened this issue Jun 12, 2024 · 5 comments
Closed

Support tracing the ClickHouse Java HTTP client #11562

devurandom opened this issue Jun 12, 2024 · 5 comments
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request needs triage New issue that requires triage new instrumentation

Comments

@devurandom
Copy link

devurandom commented Jun 12, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

ClickHouse Java HTTP client (https://github.com/ClickHouse/clickhouse-java) queries currently show up only as HTTP traces.

Describe the solution you'd like

It would be nice if queries by the ClickHouse Java HTTP client were instrumented like database requests (in addition to the underlying HTTP requests), e.g. with a db.query.text, cf. https://opentelemetry.io/docs/specs/semconv/database/database-spans/.

Describe alternatives you've considered

  • Automatic HTTP client instrumentation shows that a request happens, but not the query. Relying on them is not an alternative.
  • Manual instrumentation of code that calls the ClickHouse Java HTTP client. This works, but is inconvenient.

Additional context

No response
@devurandom devurandom added enhancement New feature or request needs triage New issue that requires triage labels Jun 12, 2024
@devurandom devurandom changed the title Support ClickHouse Java HTTP client Support tracing the ClickHouse Java HTTP client Jun 12, 2024
@laurit laurit added contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome new instrumentation labels Jun 12, 2024
@laurit
Copy link
Contributor

laurit commented Jun 12, 2024

We'd welcome a contribution for this

@jaydeluca
Copy link
Member

@devurandom are you planning on contributing this? Otherwise I am interested in working on it.

@devurandom
Copy link
Author

@devurandom are you planning on contributing this? Otherwise I am interested in working on it.

Please go ahead! :)

@jaydeluca jaydeluca mentioned this issue Jun 23, 2024
Merged
@devurandom
Copy link
Author

#11660 was merged. Should this be closed? Or will that happen when 2.6.0 is released?

@laurit
Copy link
Contributor

laurit commented Jul 10, 2024

Resolved with #11660

@laurit laurit closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request needs triage New issue that requires triage new instrumentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@devurandom @laurit @jaydeluca