-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize HttpClientTracer methods for invalid spans #1009
Comments
@trask Would you mind adding a little detail about what makes a span invalid and what that optimization might look like? |
@breedx-splk thx, #1840 addresses this, I'll note in that PR that it closes this issue |
@trask the PR you linked probably isn't going to be merged soon (😄 ), would you mind adding some explanation here? (Or closing this issue if it's no longer valid) |
oh ya, this is done now / no longer valid 👍 |
In particular,
startScope(Span, ...)
andend*(Span, ...)
methods can be optimized for invalid spans.This will be important after removing
CallDepth
(#907) which will then make the invalid span route more common.The text was updated successfully, but these errors were encountered: