Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize HttpClientTracer methods for invalid spans #1009

Closed
trask opened this issue Aug 15, 2020 · 4 comments
Closed

Optimize HttpClientTracer methods for invalid spans #1009

trask opened this issue Aug 15, 2020 · 4 comments

Comments

@trask
Copy link
Member

trask commented Aug 15, 2020

In particular, startScope(Span, ...) and end*(Span, ...) methods can be optimized for invalid spans.

This will be important after removing CallDepth (#907) which will then make the invalid span route more common.

@breedx-splk
Copy link
Contributor

@trask Would you mind adding a little detail about what makes a span invalid and what that optimization might look like?

@trask
Copy link
Member Author

trask commented Dec 12, 2020

@breedx-splk thx, #1840 addresses this, I'll note in that PR that it closes this issue

@mateuszrzeszutek
Copy link
Member

@trask the PR you linked probably isn't going to be merged soon (😄 ), would you mind adding some explanation here? (Or closing this issue if it's no longer valid)

@trask
Copy link
Member Author

trask commented Mar 8, 2021

oh ya, this is done now / no longer valid 👍

@trask trask closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants