From 1ee063a0d89c769c94b84ce3535f5f9332bbef9c Mon Sep 17 00:00:00 2001 From: Gregor Zeitlinger Date: Wed, 21 Aug 2024 17:47:12 +0200 Subject: [PATCH] use camelCase, correct package --- .../spring/batch/v3_0/basic/SpringBatchTest.java | 14 +++++++------- .../spring/batch/v3_0/chunk/ChunkRootSpanTest.java | 2 +- .../batch/v3_0/event/CustomSpanEventTest.java | 2 +- .../spring/batch/v3_0/item/ItemLevelSpanTest.java | 4 ++-- .../v3_0/item/JsrConfigItemLevelSpanTest.java | 4 ++-- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/basic/SpringBatchTest.java b/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/basic/SpringBatchTest.java index 2230e0d6e8b1..8bf57a568b0f 100644 --- a/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/basic/SpringBatchTest.java +++ b/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/basic/SpringBatchTest.java @@ -36,7 +36,7 @@ public SpringBatchTest(JobRunner runner) { } @Test - void should_trace_tasklet_job_step() { + void shouldTraceTaskletJobStep() { runner.runJob("taskletJob"); testing.waitAndAssertTraces( @@ -57,7 +57,7 @@ void should_trace_tasklet_job_step() { } @Test - void should_handle_exception_in_tasklet_job_step() { + void shouldHandleExceptionInTaskletJobStep() { runner.runJob("taskletJob", singletonMap("fail", new JobParameter(1L))); testing.waitAndAssertTraces( @@ -81,7 +81,7 @@ void should_handle_exception_in_tasklet_job_step() { } @Test - void should_trace_chunked_items_job() { + void shouldTraceChunkedItemsJob() { runner.runJob("itemsAndTaskletJob"); testing.waitAndAssertTraces( @@ -115,7 +115,7 @@ void should_trace_chunked_items_job() { } @Test - void should_trace_flow_job() { + void shouldTraceFlowJob() { runner.runJob("flowJob"); testing.waitAndAssertTraces( @@ -144,7 +144,7 @@ void should_trace_flow_job() { } @Test - void should_trace_split_flow_job() { + void shouldTraceSplitFlowJob() { runner.runJob("splitJob"); testing.waitAndAssertTraces( @@ -185,7 +185,7 @@ void should_trace_split_flow_job() { } @Test - void should_trace_job_with_decision() { + void shouldTraceJobWithDecision() { runner.runJob("decisionJob"); testing.waitAndAssertTraces( @@ -214,7 +214,7 @@ void should_trace_job_with_decision() { } @Test - void should_trace_partitioned_job() { + void shouldTracePartitionedJob() { runner.runJob("partitionedJob"); testing.waitAndAssertTraces( diff --git a/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/chunk/ChunkRootSpanTest.java b/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/chunk/ChunkRootSpanTest.java index d1d295910882..058d5be2eb3e 100644 --- a/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/chunk/ChunkRootSpanTest.java +++ b/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/chunk/ChunkRootSpanTest.java @@ -34,7 +34,7 @@ public ChunkRootSpanTest(JobRunner jobRunner) { } @Test - void should_create_separate_traces_for_each_chunk() { + void shouldCreateSeparateTracesForEachChunk() { jobRunner.runJob("itemsAndTaskletJob"); AtomicReference itemStepSpan = new AtomicReference<>(); AtomicReference taskletStepSpan = new AtomicReference<>(); diff --git a/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/event/CustomSpanEventTest.java b/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/event/CustomSpanEventTest.java index 9c9dc65f2127..9906383dfe6e 100644 --- a/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/event/CustomSpanEventTest.java +++ b/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/event/CustomSpanEventTest.java @@ -27,7 +27,7 @@ public CustomSpanEventTest(JobRunner runner) { } @Test - void should_be_able_to_call_Span_current___and_add_custom_info_to_spans() { + void shouldBeAbleToCallSpanCurrentAndAddCustomInfoToSpans() { runner.runJob("customSpanEventsItemsJob"); testing.waitAndAssertTraces( diff --git a/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/item/ItemLevelSpanTest.java b/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/item/ItemLevelSpanTest.java index 376ee30509ec..b9ab72095edb 100644 --- a/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/item/ItemLevelSpanTest.java +++ b/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/item/ItemLevelSpanTest.java @@ -35,7 +35,7 @@ public ItemLevelSpanTest(JobRunner runner) { } @Test - void should_trace_item_read__process_and_write_calls() { + void shouldTraceItemReadProcessAndWriteCalls() { runner.runJob("itemsAndTaskletJob"); testing.waitAndAssertTraces( @@ -148,7 +148,7 @@ void should_trace_item_read__process_and_write_calls() { } @Test - void should_trace_all_item_operations_on_a_parallel_items_job() { + void shouldTraceAllItemOperationsOnAParallelItemsJob() { runner.runJob("parallelItemsJob"); testing.waitAndAssertTraces( diff --git a/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/item/JsrConfigItemLevelSpanTest.java b/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/item/JsrConfigItemLevelSpanTest.java index e20c9da17efa..03ecf368644a 100644 --- a/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/item/JsrConfigItemLevelSpanTest.java +++ b/instrumentation/spring/spring-batch-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/item/JsrConfigItemLevelSpanTest.java @@ -20,7 +20,7 @@ public JsrConfigItemLevelSpanTest() { @Test @Override - public void should_trace_item_read__process_and_write_calls() { + public void shouldTraceItemReadProcessAndWriteCalls() { runner.runJob("itemsAndTaskletJob"); testing.waitAndAssertTraces( @@ -161,7 +161,7 @@ public void should_trace_item_read__process_and_write_calls() { } @Override - void should_trace_all_item_operations_on_a_parallel_items_job() { + void shouldTraceAllItemOperationsOnAParallelItemsJob() { // does not work - not sure why } }